I applaud anyone willing to take the time and effort to teach others (including myself).  I can't tell you how many people i've taken to the range for either their first time or for the first time someone who knows what they are doing showed them the safety and shooting basics.  Too many were handed a firearm by a friend or relative and told, "See if you can hit that target."

i also supplied the firearms, did all the cleaning (for days!), and bought all the ammo.  Most would hand me $10-$20, or occasionally more depending on the amount of ammo they used.

What i'm advocating for is the NRA as an organization financially supporting these efforts.  Have ranges offer discounted packages, and have the NRA offset the cost.  It should be easy to prevent abuse and fraud.  Every shooter needs to join the NRA, so they know who you are.  Set caps on rentals, ammo cost, range cost and targets. If John practices once a week, he should be allowed to buy an NRA practice package twice each week -- in case he goes Sat & Sun.  NRA pays the range their share, and you pay the "co-pay" at the time you go shoot.  NRA member numbers can be placed on the reimbursement requests, etc.

NRA sucks up millions of dollars each year.  There's no reason they should be paying themselves and not using that to actually take care of their basic mission.  Simply training instructors who then use their credentials to solicit for paid training sessions is fine, but that isn't enough IMO.  I like that you choose to do what you do, but I don't think that's the norm.

"NRA sucks up millions of dollars each year."
That it does.   I've been a life member since the late 80's
I've watched them go from good to bad. From safety and shooting
skills to LaPieres $1000 dollar suits.
and personal jets.
They need to move to middle America.
I'm still a member but GOA gets most my donations.
I've given up on "go along to get along"  HIFICO.