Firearm as an investments is not normally a great idea due to the low volume of buying and selling, hence low liquidity. When investing in stocks, you'll normally find that a stock with low trading volume may not be as easy to dispose at current prices as a stock with a high daily average trading volume.
You could buy all the Mosin Nagants you want but what if no one wants to buy it when you need to convert it to cash? Then you'll have to discount it in order to get rid of it quicker.
Otherwise, if you are in no rush to convert them to money, then yes, some firearms seem to go up in value if they remain unused and you take good care of them. But I think most firearms are not really easy to resell, unless you stick to the ones with good collectors value. Kinda like collecting baseball cards.
Of course, current events and economics can change this. During the gold rush, folks making lots of money were the ones making and selling mining and gold panning tools and gear to the ones seeking their fortune in gold. I suppose if there was societal collapse and roaming bands of looters popped up all over, I'm sure there will be high value to any firearm or ammo you may have for people to defend themselves.
Lastly, if you can get a steady supply of firearms at below market prices, then you may want to consider opening a gun store!

Just my opinion.